As far as I understand, it default to `let` in these cases because the tool cannot figure out if a `const` is possible. It has to be checked manually:
```
./node_modules/lebab/bin/index.js --replace "umap/static/umap/js/*.js" --transform let
umap/static/umap/js/umap.xhr.js:
228: warning Unable to transform var (let)
umap/static/umap/js/umap.ui.js:
83: warning Unable to transform var (let)
umap/static/umap/js/umap.slideshow.js:
15: warning Unable to transform var (let)
83: warning Unable to transform var (let)
umap/static/umap/js/umap.popup.js:
100: warning Unable to transform var (let)
umap/static/umap/js/umap.permissions.js:
14: warning Unable to transform var (let)
umap/static/umap/js/umap.layer.js:
195: warning Unable to transform var (let)
436: warning Unable to transform var (let)
568: warning Unable to transform var (let)
584: warning Unable to transform var (let)
989: warning Unable to transform var (let)
1088: warning Unable to transform var (let)
1098: warning Unable to transform var (let)
umap/static/umap/js/umap.js:
124: warning Unable to transform var (let)
223: warning Unable to transform var (let)
343: warning Unable to transform var (let)
376: warning Unable to transform var (let)
406: warning Unable to transform var (let)
849: warning Unable to transform var (let)
732: warning Unable to transform var (let)
948: warning Unable to transform var (let)
959: warning Unable to transform var (let)
878: warning Unable to transform var (let)
1085: warning Unable to transform var (let)
umap/static/umap/js/umap.icon.js:
145: warning Unable to transform var (let)
184: warning Unable to transform var (let)
umap/static/umap/js/umap.forms.js:
453: warning Unable to transform var (let)
umap/static/umap/js/umap.features.js:
15: warning Unable to transform var (let)
101: warning Unable to transform var (let)
143: warning Unable to transform var (let)
373: warning Unable to transform var (let)
429: warning Unable to transform var (let)
890: warning Unable to transform var (let)
949: warning Unable to transform var (let)
umap/static/umap/js/umap.core.js:
149: warning Unable to transform var (let)
175: warning Unable to transform var (let)
umap/static/umap/js/umap.controls.js:
665: warning Unable to transform var (let)
876: warning Unable to transform var (let)
1249: warning Unable to transform var (let)
```
new account at each login:
```
File "/srv/umap/venv/lib/python3.10/site-packages/social_core/backends/base.py", line 83, in pipeline
out = self.run_pipeline(pipeline, pipeline_index, *args, **kwargs)
File "/srv/umap/venv/lib/python3.10/site-packages/social_core/backends/base.py", line 113, in run_pipeline
result = func(*args, **out) or {}
File "/srv/umap/venv/lib/python3.10/site-packages/social_core/pipeline/user.py", line 122, in user_details
strategy.storage.user.changed(user)
File "/srv/umap/venv/lib/python3.10/site-packages/social_django/storage.py", line 16, in changed
user.save()
django.db.utils.IntegrityError: duplicate key value violates unique constraint "auth_user_username_key"
DETAIL: Key (username)=(xxxxx) already exists.
```
Since this commit 97e2df0a8d tests were broken because the URL has an extra date parameter to update the cache for datalayers. With the new regexp, we match these new URLs with the fakeServer from sinon.
Also update sinon to v15.
I missed that one and I fixed a bug in the meantime setting a correct label (vs. invisible placeholder for an input of type range).
I set a fallback on the datalist id in case no label is specified (which is probably not a good idea).
