jeff/umap
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: delete map from dashboard confirm was not active

Browse source
This commit is contained in:
Yohan Boniface 2024-02-09 18:58:58 +01:00
parent ef06ca46b3
commit 92cc014c2e
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
umap/templates/umap/map_table.html
View file

@ -123,7 +123,7 @@
{% endif %} {% endif %}
<script> <script>
!(function () { !(function () {
for (const deleteForm of document.querySelectorAll('table.maps form.map-delete')) { for (const deleteForm of document.querySelectorAll('form.map-delete')) {
deleteForm.addEventListener('submit', (event) => { deleteForm.addEventListener('submit', (event) => {
if (!confirm(L._('Are you sure you want to delete this map?'))) { if (!confirm(L._('Are you sure you want to delete this map?'))) {
event.preventDefault() event.preventDefault()

10
umap/tests/integration/test_dashboard.py
View file

@ -7,11 +7,19 @@ pytestmark = pytest.mark.django_db
def test_owner_can_delete_map_after_confirmation(map, live_server, login): def test_owner_can_delete_map_after_confirmation(map, live_server, login):
dialog_shown = False
def handle_dialog(dialog):
dialog.accept()
nonlocal dialog_shown
dialog_shown = True
page = login(map.owner) page = login(map.owner)
page.goto(f"{live_server.url}/en/me") page.goto(f"{live_server.url}/en/me")
delete_button = page.get_by_title("Delete") delete_button = page.get_by_title("Delete")
expect(delete_button).to_be_visible() expect(delete_button).to_be_visible()
page.on("dialog", lambda dialog: dialog.accept()) page.on("dialog", handle_dialog)
with page.expect_navigation(): with page.expect_navigation():
delete_button.click() delete_button.click()
assert dialog_shown
assert Map.objects.all().count() == 0 assert Map.objects.all().count() == 0