From 92cc014c2e636a199cdf017885f6cbec87ee9db0 Mon Sep 17 00:00:00 2001
From: Yohan Boniface <yohanboniface@free.fr>
Date: Fri, 9 Feb 2024 18:58:58 +0100
Subject: [PATCH] fix: delete map from dashboard confirm was not active

---
 umap/templates/umap/map_table.html       |  2 +-
 umap/tests/integration/test_dashboard.py | 10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/umap/templates/umap/map_table.html b/umap/templates/umap/map_table.html
index 0188b377..1a0b87c7 100644
--- a/umap/templates/umap/map_table.html
+++ b/umap/templates/umap/map_table.html
@@ -123,7 +123,7 @@
 {% endif %}
 <script>
   !(function () {
-    for (const deleteForm of document.querySelectorAll('table.maps form.map-delete')) {
+    for (const deleteForm of document.querySelectorAll('form.map-delete')) {
       deleteForm.addEventListener('submit', (event) => {
         if (!confirm(L._('Are you sure you want to delete this map?'))) {
           event.preventDefault()
diff --git a/umap/tests/integration/test_dashboard.py b/umap/tests/integration/test_dashboard.py
index 654d0bc7..cb6559ff 100644
--- a/umap/tests/integration/test_dashboard.py
+++ b/umap/tests/integration/test_dashboard.py
@@ -7,11 +7,19 @@ pytestmark = pytest.mark.django_db
 
 
 def test_owner_can_delete_map_after_confirmation(map, live_server, login):
+    dialog_shown = False
+
+    def handle_dialog(dialog):
+        dialog.accept()
+        nonlocal dialog_shown
+        dialog_shown = True
+
     page = login(map.owner)
     page.goto(f"{live_server.url}/en/me")
     delete_button = page.get_by_title("Delete")
     expect(delete_button).to_be_visible()
-    page.on("dialog", lambda dialog: dialog.accept())
+    page.on("dialog", handle_dialog)
     with page.expect_navigation():
         delete_button.click()
+    assert dialog_shown
     assert Map.objects.all().count() == 0