Commit graph

1691 commits

Author SHA1 Message Date
Yohan Boniface
a15aa3566a Add playwright tests for anonymous map 2023-09-22 17:30:07 +02:00
Yohan Boniface
d902546da4 Add map update playwright tests 2023-09-22 17:30:07 +02:00
Yohan Boniface
168cc01c2e Do not try to access self.object in MapCreate 2023-09-22 17:30:07 +02:00
Yohan Boniface
42eb0e6ded Add more tests for datalayer permissions 2023-09-22 17:30:06 +02:00
Yohan Boniface
d6d55e619a Fix existing permissions related tests 2023-09-22 17:26:57 +02:00
Yohan Boniface
e52b40807a Expose correct edit statuses in anonymous mode 2023-09-22 17:26:57 +02:00
Yohan Boniface
e06da18f1e Fix helptext not displayed in anonymous permissions panel 2023-09-22 17:26:57 +02:00
Yohan Boniface
1cefd4e851 Hide create/delete datalayers button + map settings to users without rights 2023-09-22 17:26:57 +02:00
Yohan Boniface
35d7a5c550 Remove unused icon in 16.svg 2023-09-22 17:26:57 +02:00
Yohan Boniface
9189262855 Do not try to save map itself unless it has been modified 2023-09-22 17:26:57 +02:00
Yohan Boniface
ee9acf3427 Fix map check in DataLayerUpdate view 2023-09-22 17:26:57 +02:00
Yohan Boniface
70a1a1d584 Move copyToClipboard to L.Util 2023-09-22 17:26:57 +02:00
Yohan Boniface
76239ef55c Make DataLayer.isReadOnly explicit and true by default 2023-09-22 17:26:56 +02:00
Yohan Boniface
3d2e62c858 Do not use Map.edit_status anymore
But keep it for now, for data migration, and just in case
2023-09-22 17:26:55 +02:00
Yohan Boniface
de907dcb50 Do not expose readonly datalayers for features 2023-09-22 17:25:55 +02:00
Yohan Boniface
89ab029cab WIP: move edit_status from Map to DataLayer 2023-09-22 17:25:55 +02:00
Yohan Boniface
73d19e849f Refactor share_status check in datalayers views 2023-09-22 17:24:01 +02:00
Yohan Boniface
9bcc18b790
Merge pull request #1329 from umap-project/prune-gz
Prune old .gz when saving a datalayer
2023-09-22 17:14:31 +02:00
Yohan Boniface
b6b9943264 Prune old .gz when saving a datalayer
We'll not consume them.

fix #1317
2023-09-21 19:12:07 +02:00
Yohan Boniface
5b7fec5f9b
Merge pull request #1314 from openbrian/docker-compose-app-depends-on-db
Replace wait_for_database with depends_on and healthcheck.
2023-09-21 10:11:56 +02:00
Brian DeRocher
6720f76d85 Set the map option. No need for setting boolean from query string.
Only add the owner property if the feature flag (map.options.featuresHaveOwner) is enabled.

Default to features do NOT have owners.
2023-09-20 13:16:52 -04:00
Brian DeRocher
77b56623ed Remove field from map settings form. 2023-09-20 13:07:12 -04:00
Brian DeRocher
6c58bf367d Use camelcase and fix typo. 2023-09-20 13:03:36 -04:00
Brian DeRocher
e25fb5d04f Add FeaturesHaveOwners map option.
WIP
2023-09-20 12:48:32 -04:00
Yohan Boniface
0988f2e2ee
Merge pull request #1320 from jvmatl/docker_quickstart_docs
A more newbie-friendly Docker HOWTO
2023-09-20 18:36:05 +02:00
John Martinez
7e2b20d085
Update docs/docker.md
Co-authored-by: Yohan Boniface <yohanboniface@free.fr>
2023-09-20 12:07:58 -04:00
Brian DeRocher
e76c147b65 owner is no longer a form field. 2023-09-20 10:53:27 -04:00
Brian DeRocher
35e37c2d4b Add translation for "owner". 2023-09-20 10:52:13 -04:00
Brian DeRocher
e2b789e575 Do not use the form for the owner property.
Only add the owner property to defaultProperties, if there is a user.  In other words the user can use the map without logging in.
2023-09-20 10:51:01 -04:00
Brian DeRocher
204db34282 Replace bash based waiting with python based django-probes. 2023-09-20 09:45:26 -04:00
Yohan Boniface
99831dc04d
Merge pull request #1326 from umap-project/dashboard-duplicate-map
Fix map displayed more than once in user dashboard when multiple editors
2023-09-20 15:17:38 +02:00
Yohan Boniface
f6730a9829
Update umap/views.py
Co-authored-by: David Larlet <3556+davidbgk@users.noreply.github.com>
2023-09-20 15:17:29 +02:00
Yohan Boniface
43e5391c49 Fix map displayed more than once in user dashboard when multiple editors
fix #1325
2023-09-20 11:30:05 +02:00
Yohan Boniface
d48b272837
Merge pull request #1323 from umap-project/better-document-secret-key
Better documentation for the SECRET_KEY setting
2023-09-20 08:04:00 +02:00
Yohan Boniface
5587632168
Merge pull request #1322 from jvmatl/ubuntu_from_scratch_feedback
Ran through the 'Ubuntu from Scratch' procedure using a fresh Ubuntu 22.04.3 LTS VM and took notes on what worked and what didn't.
2023-09-20 08:02:47 +02:00
Brian DeRocher
9c89c50560 Set a default property for features that the owner is the current user.
https://github.com/umap-project/umap/issues/430
2023-09-19 19:13:14 -04:00
David Larlet
408fcb7c0f
Revert "Add link to django docs for SECRET_KEY"
This reverts commit e2eb510854.
2023-09-19 14:59:31 -04:00
John Martinez
7134269218
Update docs/ubuntu.md
Co-authored-by: David Larlet <3556+davidbgk@users.noreply.github.com>
2023-09-19 14:58:21 -04:00
David Larlet
84c00fa5ba
Better documentation for the SECRET_KEY setting
See https://github.com/umap-project/umap/pull/1322#issuecomment-1726300269
2023-09-19 14:52:57 -04:00
John Martinez
e2eb510854 Add link to django docs for SECRET_KEY 2023-09-19 18:49:21 +00:00
John Martinez
93cfe80370
Update docs/docker.md
typo

Co-authored-by: David Larlet <3556+davidbgk@users.noreply.github.com>
2023-09-19 14:44:31 -04:00
John Martinez
74fd3f4a66
Update docs/docker.md
Typo

Co-authored-by: David Larlet <3556+davidbgk@users.noreply.github.com>
2023-09-19 14:43:51 -04:00
John Martinez
2f21d7b821
Update docs/docker.md
punctuation

Co-authored-by: David Larlet <3556+davidbgk@users.noreply.github.com>
2023-09-19 14:41:14 -04:00
John Martinez
89cfa7d93d Ran through the 'Ubuntu from Scratch' procedure using a fresh Ubuntu 22.04.3 LTS VM and took notes on what worked and what didn't.
Here's a summary of the changes and why

* added 'apt update' before the install -- only _needed_ on a completely fresh VM, but never hurts

* added an install of the virtualenv package, because it is used later but: do you still need it AND python3-venv? I'm assuming it was done that way for a reason.

* changed indentation on the mkdir so it will format correctly

* added `-D ~postgres` to the commands executed as postgres user because the postgres user does not, by default, have permission to read into real user's home directories (at least in 22.04) and so the commands would error out

* change `source <activate>` to `. activate` because the line `sudo -u umap -i` launches `sh`, not `bash`, and `sh` does not recognize the source command. `.` works in either.

* remove the instructions to change STATIC_ROOT and MEDIA_ROOT because they are already defaulted to those values in the current version sample of local.py

* added a notice to change the SECREY_KEY and ADMINS list just because it seemed like a good idea.

Side note: I have not seen any docs anywhere that explains exactly what the secret Key does, or where it is used. It's used a magic variable in the config file.. ?

I am not currently messing with nginx or wsgi, so I can't comment on those parts.
2023-09-19 18:32:13 +00:00
John Martinez
cc9004fbc2 Code review feedback 2023-09-19 17:43:13 +00:00
John Martinez
43a35ee5fd A more newbie-friendly Docker HOWTO 2023-09-19 17:24:32 +00:00
Yohan Boniface
038a1a3c4d
Merge pull request #1315 from umap-project/dot-in-property
Remove dot in property name
2023-09-19 07:35:10 +02:00
Yohan Boniface
466d955953
Merge pull request #1316 from umap-project/fullwidth-panel-close
Fix table editor not closing anymore from fullwidth
2023-09-18 15:33:13 +02:00
Yohan Boniface
9120d54be7 Fix table editor not closing anymore from fullwidth
(From f3b5c82767)
2023-09-18 13:02:19 +02:00
Yohan Boniface
647d8910c0 Remove dot in property name
Otherwise it will break when trying to access it in FormBuilder
2023-09-18 12:21:06 +02:00