jeff/umap
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1582 from umap-project/test-sleep

Browse source 
tests: remove sleep from test_owned_map
This commit is contained in:
Yohan Boniface 2024-02-07 15:31:02 +01:00 committed by GitHub
commit f209f76e67
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
umap/tests/integration/test_owned_map.py
View file

@ -1,4 +1,4 @@
from time import sleep import re
import pytest import pytest
from playwright.sync_api import expect from playwright.sync_api import expect
@ -20,7 +20,6 @@ def login(context, settings, live_server):
page.get_by_placeholder("Username").fill(user.username) page.get_by_placeholder("Username").fill(user.username)
page.get_by_placeholder("Password").fill("123123") page.get_by_placeholder("Password").fill("123123")
page.locator('#login_form input[type="submit"]').click() page.locator('#login_form input[type="submit"]').click()
sleep(1) # Time for ajax login POST to proceed
return page return page
return do_login return do_login
@ -183,8 +182,8 @@ def test_create(tilelayer, live_server, login, user):
expect(marker).to_have_count(1) expect(marker).to_have_count(1)
save = page.get_by_role("button", name="Save") save = page.get_by_role("button", name="Save")
expect(save).to_be_visible() expect(save).to_be_visible()
save.click() with page.expect_response(re.compile(r".*/datalayer/create/")):
sleep(1) # Let save ajax go back save.click()
expect(marker).to_have_count(1) expect(marker).to_have_count(1)
@ -197,8 +196,8 @@ def test_can_change_perms_after_create(tilelayer, live_server, login, user):
page.locator("input[name=name]").fill("Layer 1") page.locator("input[name=name]").fill("Layer 1")
save = page.get_by_role("button", name="Save") save = page.get_by_role("button", name="Save")
expect(save).to_be_visible() expect(save).to_be_visible()
save.click() with page.expect_response(re.compile(r".*/map/create/")):
sleep(1) # Let save ajax go back save.click()
edit_permissions = page.get_by_title("Update permissions and editors") edit_permissions = page.get_by_title("Update permissions and editors")
expect(edit_permissions).to_be_visible() expect(edit_permissions).to_be_visible()
edit_permissions.click() edit_permissions.click()
@ -232,7 +231,7 @@ def test_can_change_owner(map, live_server, login, user):
input.press("Tab") input.press("Tab")
save = page.get_by_role("button", name="Save") save = page.get_by_role("button", name="Save")
expect(save).to_be_visible() expect(save).to_be_visible()
save.click() with page.expect_response(re.compile(r".*/update/permissions/.*")):
sleep(1) # Let save ajax go save.click()
modified = Map.objects.get(pk=map.pk) modified = Map.objects.get(pk=map.pk)
assert modified.owner == user assert modified.owner == user