From b4464a7ca21542798d0775facb91d787225269c7 Mon Sep 17 00:00:00 2001 From: David Larlet Date: Fri, 24 Nov 2023 15:28:58 -0500 Subject: [PATCH 1/2] Reuse the map_download view/url for the dashboard Refs #1396 --- umap/templates/umap/map_table.html | 2 +- umap/tests/test_views.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/umap/templates/umap/map_table.html b/umap/templates/umap/map_table.html index eb8cef5a..63eb90d7 100644 --- a/umap/templates/umap/map_table.html +++ b/umap/templates/umap/map_table.html @@ -27,7 +27,7 @@ {% translate "Share" %} {% translate "Edit" %} - {% translate "Download" %} + {% translate "Download" %} {% endfor %} diff --git a/umap/tests/test_views.py b/umap/tests/test_views.py index 1fced968..25f080a3 100644 --- a/umap/tests/test_views.py +++ b/umap/tests/test_views.py @@ -280,7 +280,7 @@ def test_user_dashboard_display_user_maps(client, map): assert map.name in body assert f"{map.get_absolute_url()}?edit" in body assert f"{map.get_absolute_url()}?share" in body - assert f"{map.get_absolute_url()}?download" in body + assert f"/map/{map.pk}/download" in body assert "Everyone (public)" in body assert "Owner only" in body From 56bb414113dbb41a5f8ad73ffb08e6351689f699 Mon Sep 17 00:00:00 2001 From: David Larlet Date: Fri, 24 Nov 2023 15:32:44 -0500 Subject: [PATCH 2/2] Provide space/separators between Dashboard actions --- umap/templates/umap/map_table.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/umap/templates/umap/map_table.html b/umap/templates/umap/map_table.html index 63eb90d7..e4df76b7 100644 --- a/umap/templates/umap/map_table.html +++ b/umap/templates/umap/map_table.html @@ -25,8 +25,8 @@ {{ map_inst.owner }} - {% translate "Share" %} - {% translate "Edit" %} + {% translate "Share" %} | + {% translate "Edit" %} | {% translate "Download" %}