From 0a75998f116c6e9829c572fb83f676b3165e8bf9 Mon Sep 17 00:00:00 2001 From: David Larlet Date: Tue, 30 May 2023 14:53:53 -0400 Subject: [PATCH] Apply Lebab for template conversions --- Makefile | 1 + umap/static/umap/js/umap.autocomplete.js | 10 +++--- umap/static/umap/js/umap.controls.js | 37 ++++++++----------- umap/static/umap/js/umap.core.js | 18 +++++----- umap/static/umap/js/umap.features.js | 11 +++--- umap/static/umap/js/umap.forms.js | 18 +++++----- umap/static/umap/js/umap.icon.js | 10 ++---- umap/static/umap/js/umap.js | 46 ++++++++++++------------ umap/static/umap/js/umap.layer.js | 11 +++--- umap/static/umap/js/umap.permissions.js | 2 +- umap/static/umap/js/umap.popup.js | 6 ++-- umap/static/umap/js/umap.slideshow.js | 2 +- umap/static/umap/js/umap.tableeditor.js | 4 +-- umap/static/umap/js/umap.ui.js | 8 ++--- 14 files changed, 85 insertions(+), 99 deletions(-) diff --git a/Makefile b/Makefile index a0a2679c..89d5e527 100644 --- a/Makefile +++ b/Makefile @@ -61,6 +61,7 @@ pretty: ## Apply PrettierJS to all JS files (or specified `filepath`) lebab: ## Convert JS `filepath` to modern syntax with Lebab, then prettify ./node_modules/lebab/bin/index.js --replace ${filepath} --transform arrow,arrow-return ./node_modules/lebab/bin/index.js --replace ${filepath} --transform let + ./node_modules/lebab/bin/index.js --replace ${filepath} --transform template $(MAKE) pretty filepath=${filepath} lebab-all: $(jsdir)* ## Convert all JS files to modern syntax with Lebab + prettify diff --git a/umap/static/umap/js/umap.autocomplete.js b/umap/static/umap/js/umap.autocomplete.js index a2340430..1f9b65cb 100644 --- a/umap/static/umap/js/umap.autocomplete.js +++ b/umap/static/umap/js/umap.autocomplete.js @@ -61,10 +61,10 @@ L.U.AutoComplete = L.Class.extend({ resizeContainer: function () { const l = this.getLeft(this.input) const t = this.getTop(this.input) + this.input.offsetHeight - this.container.style.left = l + 'px' - this.container.style.top = t + 'px' + this.container.style.left = `${l}px` + this.container.style.top = `${t}px` const width = this.options.width ? this.options.width : this.input.offsetWidth - 2 - this.container.style.width = width + 'px' + this.container.style.width = `${width}px` }, onKeyDown: function (e) { @@ -164,7 +164,7 @@ L.U.AutoComplete = L.Class.extend({ this.clear() return } - if (val + '' === this.CACHE + '') return + if (`${val}` === `${this.CACHE}`) return else this.CACHE = val this._do_search( val, @@ -275,7 +275,7 @@ L.U.AutoComplete.Ajax = L.U.AutoComplete.extend({ _do_search: function (val, callback, context) { val = val.toLowerCase() - this.xhr.get('/agnocomplete/AutocompleteUser/?q=' + encodeURIComponent(val), { + this.xhr.get(`/agnocomplete/AutocompleteUser/?q=${encodeURIComponent(val)}`, { callback: callback, context: context || this, }) diff --git a/umap/static/umap/js/umap.controls.js b/umap/static/umap/js/umap.controls.js index 0985cd5c..8c1a5c0f 100644 --- a/umap/static/umap/js/umap.controls.js +++ b/umap/static/umap/js/umap.controls.js @@ -15,7 +15,7 @@ L.U.ImportAction = L.U.BaseAction.extend({ options: { helpMenu: true, className: 'upload-data dark', - tooltip: L._('Import data') + ' (Ctrl+I)', + tooltip: `${L._('Import data')} (Ctrl+I)`, }, addHooks: function () { @@ -320,7 +320,7 @@ L.U.EditControl = L.Control.extend({ ), edit = L.DomUtil.create('a', '', container) edit.href = '#' - edit.title = L._('Enable editing') + ' (Ctrl+E)' + edit.title = `${L._('Enable editing')} (Ctrl+E)` L.DomEvent.addListener(edit, 'click', L.DomEvent.stop).addListener( edit, @@ -542,7 +542,7 @@ L.U.DataLayersControl = L.Control.extend({ datalayer.options.name ) - datalayerLi.id = 'browse_data_toggle_' + L.stamp(datalayer) + datalayerLi.id = `browse_data_toggle_${L.stamp(datalayer)}` L.DomUtil.classIf(datalayerLi, 'off', !datalayer.isVisible()) title.textContent = datalayer.options.name @@ -626,11 +626,11 @@ L.U.DataLayer.include({ }, getHidableElements: function () { - return document.querySelectorAll('.' + this.getHidableClass()) + return document.querySelectorAll(`.${this.getHidableClass()}`) }, getHidableClass: function () { - return 'show_with_datalayer_' + L.stamp(this) + return `show_with_datalayer_${L.stamp(this)}` }, propagateRemote: function () { @@ -689,7 +689,7 @@ L.U.Map.include({ filter.value = this.options.filter || '' const addFeature = (feature) => { - const feature_li = L.DomUtil.create('li', feature.getClassName() + ' feature'), + const feature_li = L.DomUtil.create('li', `${feature.getClassName()} feature`), zoom_to = L.DomUtil.create('i', 'feature-zoom_to', feature_li), edit = L.DomUtil.create('i', 'show-on-edit feature-edit', feature_li), color = L.DomUtil.create('i', 'feature-color', feature_li), @@ -702,7 +702,7 @@ L.U.Map.include({ title.textContent = feature.getDisplayName() || '—' color.style.backgroundColor = feature.getOption('color') if (symbol) { - color.style.backgroundImage = 'url(' + symbol + ')' + color.style.backgroundImage = `url(${symbol})` } L.DomEvent.on( zoom_to, @@ -740,7 +740,7 @@ L.U.Map.include({ featuresContainer ), headline = L.DomUtil.create('h5', '', container) - container.id = 'browse_data_datalayer_' + datalayer.umap_id + container.id = `browse_data_datalayer_${datalayer.umap_id}` datalayer.renderToolbox(headline) L.DomUtil.add('span', '', headline, datalayer.options.name) const ul = L.DomUtil.create('ul', '', container) @@ -1009,18 +1009,18 @@ L.U.AttributionControl = L.Control.Attribution.extend({ 'span', '', this._container, - ' — ' + L.Util.toHTML(this._map.options.shortCredit) + ` — ${L.Util.toHTML(this._map.options.shortCredit)}` ) } if (this._map.options.captionMenus) { - const link = L.DomUtil.add('a', '', this._container, ' — ' + L._('About')) + const link = L.DomUtil.add('a', '', this._container, ` — ${L._('About')}`) L.DomEvent.on(link, 'click', L.DomEvent.stop) .on(link, 'click', this._map.displayCaption, this._map) .on(link, 'dblclick', L.DomEvent.stop) } if (window.top === window.self && this._map.options.captionMenus) { // We are not in iframe mode - const home = L.DomUtil.add('a', '', this._container, ' — ' + L._('Home')) + const home = L.DomUtil.add('a', '', this._container, ` — ${L._('Home')}`) home.href = '/' } }, @@ -1035,7 +1035,7 @@ L.U.StarControl = L.Control.extend({ const status = map.options.starred ? ' starred' : '' const container = L.DomUtil.create( 'div', - 'leaflet-control-star umap-control' + status + `leaflet-control-star umap-control${status}` ), link = L.DomUtil.create('a', '', container) link.href = '#' @@ -1254,21 +1254,14 @@ L.U.IframeExporter = L.Evented.extend({ delete this.queryString.datalayers } const currentView = this.options.currentView ? window.location.hash : '' - return this.baseUrl + '?' + L.Util.buildQueryString(this.queryString) + currentView + return `${this.baseUrl}?${L.Util.buildQueryString(this.queryString)}${currentView}` }, build: function () { const iframeUrl = this.buildUrl() - const code = - '' + const code = `` if (this.options.includeFullScreenLink) { - code += '

' + L._('See full screen') + '

' + code += `

${L._('See full screen')}

` } return code }, diff --git a/umap/static/umap/js/umap.core.js b/umap/static/umap/js/umap.core.js index 483db35e..8f9dbc39 100644 --- a/umap/static/umap/js/umap.core.js +++ b/umap/static/umap/js/umap.core.js @@ -70,7 +70,7 @@ L.Util.toHTML = (r) => { r = r.replace(/^\*\* (.*)/gm, '') r = r.replace(/^\* (.*)/gm, '') for (ii = 0; ii < 3; ii++) - r = r.replace(new RegExp('' + newline + '${newline}