jeff/umap
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Catch unkown domain in validate_url

Browse source
This commit is contained in:
Yohan Boniface 2014-07-18 23:26:16 +02:00
parent 7550664030
commit 469187e4f1
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
umap/tests/test_views.py
View file

@ -55,6 +55,11 @@ class TestsValidateProxyURL(TestCase):
with self.assertRaises(AssertionError): with self.assertRaises(AssertionError):
validate_url(request) validate_url(request)
def test_unkown_domain_raises(self):
request = self.buildRequest("http://xlkjdkjsdlkjfd.com")
with self.assertRaises(AssertionError):
validate_url(request)
class TestsProxy(TestCase): class TestsProxy(TestCase):

3
umap/views.py
View file

@ -207,8 +207,11 @@ def validate_url(request):
assert referer.hostname == local.hostname assert referer.hostname == local.hostname
assert toproxy.hostname != "localhost" assert toproxy.hostname != "localhost"
assert toproxy.netloc != local.netloc assert toproxy.netloc != local.netloc
try:
# clean this when in python 3.4 # clean this when in python 3.4
ipaddress = socket.gethostbyname(toproxy.hostname) ipaddress = socket.gethostbyname(toproxy.hostname)
except:
raise AssertionError()
assert not ipaddress.startswith('127.') assert not ipaddress.startswith('127.')
assert not ipaddress.startswith('192.168.') assert not ipaddress.startswith('192.168.')
return url return url