jeff/umap
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevent HTML blinking when loading icons list

Browse source
This commit is contained in:
Yohan Boniface 2023-09-05 11:21:17 +02:00
parent d72ae3fc34
commit 4009e759dc
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
umap/static/umap/js/umap.forms.js
View file

@ -532,7 +532,7 @@ L.FormBuilder.IconUrl = L.FormBuilder.BlurInput.extend({
}, },
isUrl: function () { isUrl: function () {
return this.value().indexOf('/') !== -1 return this.value() && this.value().indexOf('/') !== -1
}, },
udpatePreview: function () { udpatePreview: function () {
@ -608,8 +608,6 @@ L.FormBuilder.IconUrl = L.FormBuilder.BlurInput.extend({
}, },
buildIconList: function (data) { buildIconList: function (data) {
this.pictogramsContainer.innerHTML = ''
this.buttonsContainer.innerHTML = ''
this.searchInput = L.DomUtil.create('input', '', this.pictogramsContainer) this.searchInput = L.DomUtil.create('input', '', this.pictogramsContainer)
this.searchInput.type = 'search' this.searchInput.type = 'search'
this.searchInput.placeholder = L._('Search') this.searchInput.placeholder = L._('Search')
@ -648,6 +646,9 @@ L.FormBuilder.IconUrl = L.FormBuilder.BlurInput.extend({
}, },
fetchIconList: function (e) { fetchIconList: function (e) {
// Clean parent element before calling ajax, to prevent blinking
this.pictogramsContainer.innerHTML = ''
this.buttonsContainer.innerHTML = ''
this.builder.map.get(this.builder.map.options.urls.pictogram_list_json, { this.builder.map.get(this.builder.map.options.urls.pictogram_list_json, {
callback: this.buildIconList, callback: this.buildIconList,
context: this, context: this,