jeff/umap
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Choropleth: do not add layer before knowing the whole dataset

Browse source 
And only compute limits once.
This commit is contained in:
Yohan Boniface 2023-10-09 15:36:55 +02:00
parent d9522d9c1f
commit 35758a1e13
1 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
umap/static/umap/js/umap.layer.js
View file

@ -128,6 +128,12 @@ L.U.Layer.Choropleth = L.FeatureGroup.extend({
[],
this.datalayer.options.choropleth
)
this.datalayer.on('datachanged', this.redraw, this)
},
redraw: function () {
this.computeLimits()
if (this._map) this.eachLayer(this._map.addLayer, this._map)
},
_getValue: function (feature) {
@ -165,13 +171,17 @@ L.U.Layer.Choropleth = L.FeatureGroup.extend({
},
addLayer: function (layer) {
this.computeLimits()
L.FeatureGroup.prototype.addLayer.call(this, layer)
// Do not add yet the layer to the map
// wait for datachanged event, so we want compute limits once
var id = this.getLayerId(layer);
this._layers[id] = layer;
return this;
},
removeLayer: function (layer) {
this.computeLimits()
L.FeatureGroup.prototype.removeLayer.call(this, layer)
var id = layer in this._layers ? layer : this.getLayerId(layer);
delete this._layers[id];
return this;
},
onAdd: function (map) {