jeff/starlink-grpc-tools
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove usage of another obsolete field

Browse source 
last_24h_obstructed_s has been removed from the grpc service protocol, along with all the other deprecated fields. This renders the seconds_obstructed item in the status mode group useless.

This is the down side of using reflection at run time to pull the protocol definitions. If something gets removed from the protocol that is still being used, it will break the run time instead of just returning default values. Then again, if it gets removed from the protocol, it's no longer useful, anyway.

This should address issue #35.
This commit is contained in:
sparky8512 2021-10-25 07:39:48 -07:00
parent 0ba1de9c66
commit b0f40c7dd7
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
starlink_grpc.py
View file

@ -60,16 +60,13 @@ This group holds information about the current state of the user terminal.
: **fraction_obstructed** : The fraction of total area (or possibly fraction : **fraction_obstructed** : The fraction of total area (or possibly fraction
of time?) that the user terminal has determined to be obstructed between of time?) that the user terminal has determined to be obstructed between
it and the satellites with which it communicates. it and the satellites with which it communicates.
: **currently_obstructed** : Most recent sample value. See bulk history data : **currently_obstructed** : Most recent sample value. See *obstructed* in
for detail. bulk history data for detail. This item still appears to be reported by
the user terminal despite no longer appearing in the bulk history data.
: **seconds_obstructed** : The amount of time within the history buffer, : **seconds_obstructed** : The amount of time within the history buffer,
in seconds, that the user terminal determined to be obstructed, regardless in seconds, that the user terminal determined to be obstructed, regardless
of whether or not packets were able to be transmitted or received. See also of whether or not packets were able to be transmitted or received.
*count_obstructed* in general ping drop history data; this value will be **OBSOLETE**: The user terminal no longer provides this data.
equal to that value when computed across all available history samples.
NOTE: The history buffer is now much smaller than it used to be, so this
field is probably either not very useful, or may be computed differently
by the user terminal than described above.
: **obstruction_duration** : Average consecutive time, in seconds, the user : **obstruction_duration** : Average consecutive time, in seconds, the user
terminal has detected its signal to be obstructed for a period of time terminal has detected its signal to be obstructed for a period of time
that it considers "prolonged", or None if no such obstructions were that it considers "prolonged", or None if no such obstructions were
@ -638,7 +635,7 @@ def status_data(context=None):
"alerts": alert_bits, "alerts": alert_bits,
"fraction_obstructed": status.obstruction_stats.fraction_obstructed, "fraction_obstructed": status.obstruction_stats.fraction_obstructed,
"currently_obstructed": status.obstruction_stats.currently_obstructed, "currently_obstructed": status.obstruction_stats.currently_obstructed,
"seconds_obstructed": status.obstruction_stats.last_24h_obstructed_s, "seconds_obstructed": None, # obsoleted in grpc service
"obstruction_duration": obstruction_duration, "obstruction_duration": obstruction_duration,
"obstruction_interval": obstruction_interval, "obstruction_interval": obstruction_interval,
"direction_azimuth": status.boresight_azimuth_deg, "direction_azimuth": status.boresight_azimuth_deg,