From 9a57c93d738e603b8ab7e58fb3f534ad04e40b6f Mon Sep 17 00:00:00 2001 From: sparky8512 <76499194+sparky8512@users.noreply.github.com> Date: Sat, 16 Jan 2021 20:12:22 -0800 Subject: [PATCH] Back out changing the default command options Per review feedback, this could have interfered with the ability to set this option via environment variable. It was a bit messy, anyway. --- Dockerfile | 4 ++-- README.md | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Dockerfile b/Dockerfile index 900ee20..b909990 100644 --- a/Dockerfile +++ b/Dockerfile @@ -19,7 +19,7 @@ WORKDIR /app # run crond as main process of container ENTRYPOINT ["/bin/sh", "/app/entrypoint.sh"] -CMD ["dishStatusInflux.py", "-t", "30"] +CMD ["dishStatusInflux.py"] # docker run -d --name='starlink-grpc-tools' -e INFLUXDB_HOST=192.168.1.34 -e INFLUXDB_PORT=8086 -e INFLUXDB_DB=starlink -# --net='br0' --ip='192.168.1.39' neurocis/starlink-grpc-tools dishStatusInflux.py -t 30 +# --net='br0' --ip='192.168.1.39' neurocis/starlink-grpc-tools dishStatusInflux.py diff --git a/README.md b/README.md index 5bea7dc..78960f3 100644 --- a/README.md +++ b/README.md @@ -110,11 +110,13 @@ docker run -d -t --name='starlink-grpc-tools' -e INFLUXDB_HOST={InfluxDB Hostnam -e INFLUXDB_USER={Optional, InfluxDB Username} \ -e INFLUXDB_PWD={Optional, InfluxDB Password} \ -e INFLUXDB_DB={Pre-created DB name, starlinkstats works well} \ - neurocis/starlink-grpc-tools dishStatusInflux.py -v -t 30 + neurocis/starlink-grpc-tools dishStatusInflux.py -v ``` The `-t` option to `docker run` will prevent Python from buffering the script's standard output and can be omitted if you don't care about seeing the verbose output in the container logs as soon as it is printed. -The `dishStatusInflux.py -v -t 30` is optional and omitting it will run same but not verbose, or you can replace it with one of the other scripts if you wish to run that instead, or use other command line options. There is also a `GrafanaDashboard - Starlink Statistics.json` which can be imported to get some charts like: +The `dishStatusInflux.py -v` is optional and omitting it will run same but not verbose, or you can replace it with one of the other scripts if you wish to run that instead, or use other command line options. There is also a `GrafanaDashboard - Starlink Statistics.json` which can be imported to get some charts like: ![image](https://user-images.githubusercontent.com/945191/104257179-ae570000-5431-11eb-986e-3fedd04bfcfb.png) + +You'll probably want to run with the `-t` option to `dishStatusInflux.py` to collect status information periodically for this to be meaningful.